Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed adaptive_he to adaptive_histogram_equalization #638

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

Paul92
Copy link
Contributor

@Paul92 Paul92 commented Mar 17, 2022

Description

On develop, tests were failing because of missing adaptive_he.cpp, which was renamed to adaptive_histogram_equalization.cpp.
Since adaptive_histogram_equalization seems more consistent, I took the liberty to modify all the occurences of adaptive_he to `adaptive_histogram_equalization.

References

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. You changed the source file name in jamfile but forgot to change the name of the actual file :)

@Paul92
Copy link
Contributor Author

Paul92 commented Mar 17, 2022

Thanks for your comment. It's either me being confused or not making myself clear, but the problem was that the tests weren't working since adaptive_histogram_equalization.cpp was already renamed (hence the tests not working) - I just renamed the rest.

@Paul92 Paul92 requested a review from lpranam March 17, 2022 18:55
@sdebionne
Copy link
Contributor

Maybe the confusion comes from the fact that this MR also renames the documentation .md file for consistency (which is fine).

@sdebionne
Copy link
Contributor

I believe the failing pipelines have nothing to do with the changes introduced in this PR:

testing.capture-output bin.v2/libs/gil/test/extension/io/simple_all_formats.test/gcc-8/release/cxxstd-2a-iso/threading-multi/visibility-hidden/simple_all_formats.run
====== BEGIN OUTPUT ======
Segmentation fault (core dumped)

EXIT STATUS: 139
====== END OUTPUT ======

The runners are probably running out of memory (or cxxstd-2a-iso is buggy in GCC8).

@mloskot
Copy link
Member

mloskot commented Mar 22, 2022

@sdebionne Yes, I think this can be merged.

It's shame the CI is still broken, but my work here mloskot#3 is still being kind of blocked by boostorg/filesystem#226 aka boostorg/cmake#17

Although with this #636 merged, it should be easier to work around it. I'll pick the task this week yet.

@mloskot mloskot added this to the Boost 1.78+ milestone Apr 21, 2022
@mloskot mloskot self-assigned this Apr 21, 2022
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm going to merge this.

If it causes any CI failures, then I'll take care of them.

@mloskot mloskot merged commit caf92fa into boostorg:develop Apr 21, 2022
@mloskot mloskot mentioned this pull request May 12, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants