-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed adaptive_he to adaptive_histogram_equalization #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. You changed the source file name in jamfile but forgot to change the name of the actual file :)
Thanks for your comment. It's either me being confused or not making myself clear, but the problem was that the tests weren't working since |
Maybe the confusion comes from the fact that this MR also renames the documentation |
I believe the failing pipelines have nothing to do with the changes introduced in this PR:
The runners are probably running out of memory (or |
@sdebionne Yes, I think this can be merged. It's shame the CI is still broken, but my work here mloskot#3 is still being kind of blocked by boostorg/filesystem#226 aka boostorg/cmake#17 Although with this #636 merged, it should be easier to work around it. I'll pick the task this week yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm going to merge this.
If it causes any CI failures, then I'll take care of them.
Description
On develop, tests were failing because of missing
adaptive_he.cpp
, which was renamed toadaptive_histogram_equalization.cpp
.Since
adaptive_histogram_equalization
seems more consistent, I took the liberty to modify all the occurences ofadaptive_he
to `adaptive_histogram_equalization.References
Tasklist