Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port TuttleOFX extension : aligned #583

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from

Conversation

meshtag
Copy link
Member

@meshtag meshtag commented Mar 17, 2021

Description

This pull request intends to port aligned extension from TuttleOFX repository to Gil as mentioned in #449 .

I have tried not to change anything significant in actual extension code. However, I have reformatted test cases completely in order to align them with current practices followed by Gil.

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@meshtag meshtag changed the title Port TuttleOFX extension : align Port TuttleOFX extension : aligned Mar 17, 2021
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs to receive similar changes as #581 (review) and #582 (review)

The tests for the feature need to pass in the CI builds but currently they fail,
e.g. https://github.com/boostorg/gil/pull/583/checks?check_run_id=2182957498#step:6:626

====== BEGIN OUTPUT ======
libs/gil/test/extension/toolbox/aligned.cpp(288): test 'gil::equal_pixels(obtained_center_middle_view, gil::view(expected_center_middle_img))' failed in function 'int main()'
libs/gil/test/extension/toolbox/aligned.cpp(289): test 'gil::equal_pixels(obtained_left_top_view, gil::view(expected_left_top_img))' failed in function 'int main()'
2 errors detected.

EXIT STATUS: 2
====== END OUTPUT ======

@mloskot mloskot added ext/toolbox boost/gil/extension/toolbox/ cat/feature New feature or functionality labels Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #583 (d5ff162) into develop (bbdce36) will increase coverage by 0.02%.
The diff coverage is 85.00%.

@@             Coverage Diff             @@
##           develop     #583      +/-   ##
===========================================
+ Coverage    78.72%   78.74%   +0.02%     
===========================================
  Files          118      119       +1     
  Lines         5034     5054      +20     
===========================================
+ Hits          3963     3980      +17     
- Misses        1071     1074       +3     

@meshtag
Copy link
Member Author

meshtag commented Apr 10, 2021

@mloskot , I will have to examine this more clearly for figuring out why this PR builds successfully on some configurations and fails for others. Currently, I am a bit busy working on my GSoC proposal and kernel generation for Sobel operator. I will try to fix this again after 13th April 2021, hence marking this PR as draft for now.

@meshtag meshtag marked this pull request as draft April 10, 2021 07:59
@mloskot
Copy link
Member

mloskot commented Apr 10, 2021

Absolutely no rush, take your time.

@meshtag meshtag marked this pull request as ready for review April 15, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/feature New feature or functionality ext/toolbox boost/gil/extension/toolbox/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants