Port TuttleOFX extension : aligned #583
Conversation
Local repository in sync with upstream
Add shrink First checkpoint test cases added Add pattern Updates Updates Port TuttleOFX extensions Improve comments Update copyright Improve copyright header Pass build Add aligned extendion Remove headers
meshtag
changed the title
There was a problem hiding this comment.
This PR needs to receive similar changes as #581 (review) and #582 (review)
The tests for the feature need to pass in the CI builds but currently they fail,
e.g. https://github.com/boostorg/gil/pull/583/checks?check_run_id=2182957498#step:6:626
====== BEGIN OUTPUT ======
libs/gil/test/extension/toolbox/aligned.cpp(288): test 'gil::equal_pixels(obtained_center_middle_view, gil::view(expected_center_middle_img))' failed in function 'int main()'
libs/gil/test/extension/toolbox/aligned.cpp(289): test 'gil::equal_pixels(obtained_left_top_view, gil::view(expected_left_top_img))' failed in function 'int main()'
2 errors detected.
EXIT STATUS: 2
====== END OUTPUT ======
mloskot
added
ext/toolbox
Codecov Report
@@ Coverage Diff @@
## develop #583 +/- ##
===========================================
+ Coverage 78.72% 78.74% +0.02%
===========================================
Files 118 119 +1
Lines 5034 5054 +20
===========================================
+ Hits 3963 3980 +17
- Misses 1071 1074 +3 |
|
@mloskot , I will have to examine this more clearly for figuring out why this PR builds successfully on some configurations and fails for others. Currently, I am a bit busy working on my GSoC proposal and kernel generation for Sobel operator. I will try to fix this again after 13th April 2021, hence marking this PR as draft for now. |
|
Absolutely no rush, take your time. |
Description
This pull request intends to port
alignedextension from TuttleOFX repository to Gil as mentioned in #449 .I have tried not to change anything significant in actual extension code. However, I have reformatted test cases completely in order to align them with current practices followed by Gil.
Tasklist