Add missing headers and remove unused typedefs #1243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awulkiew
approved these changes
Feb 24, 2024
| @@ -18,6 +18,8 @@ | |||
| #ifndef BOOST_GEOMETRY_ALGORITHMS_DETAIL_WITHIN_WITHIN_NO_TURNS_HPP | |||
| #define BOOST_GEOMETRY_ALGORITHMS_DETAIL_WITHIN_WITHIN_NO_TURNS_HPP | |||
|
|
|||
| #include <boost/type_traits/is_base_of.hpp> | |||
There was a problem hiding this comment.
Sorry, I had not seen this PR before.
And I tackled the same problem because I got a mail that my merge was red.
I think this line is not the right fix - we use it from std now (in several other places)
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| #include <boost/rational.hpp> | |||
| #include <boost/numeric/conversion/bounds.hpp> | |||
| #include <boost/numeric/conversion/converter.hpp> | |||
There was a problem hiding this comment.
So indeed this fixed it.
I fixed it in another way (again, because I didn't notice this earlier, sorry) and I think it is a better fix. See #1246
|
I see this PR is already 2 weeks old. My bad for not reviewing of course. |
|
Closing as duplicate of #1246 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes failing CI header tests (and removes some unused typedefs appeared as warnings)