Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI error handling issue #1447

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rishabh1S
Copy link
Contributor

Description

This pull request addresses the issue #1341, which involves fixing the behavior of the catch method in the Build class. Currently, when a compilation error occurs during the build process, the CLI fails silently, and errors are not displayed to the user. The purpose of this PR is to modify the code so that compilation errors are always displayed, regardless of the verbose flag.

Changes

  • Modified the catch method in the Build class to unconditionally log error messages to the console when a compilation error occurs.

Closes #1341

@ghost
Copy link

ghost commented Oct 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI not showing errors on build
1 participant