-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] 실시간으로 Coordinate 기록 시 위치 필터링 구현 #303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into iOS/task/HomeButton-Bug-Fix
… iOS/task/HomeButton-Bug-Fix
PushedGun
approved these changes
Dec 11, 2023
…023/iOS01-MusicSpot into iOS/task/HomeButton-Bug-Fix
SwiftyJunnos
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
현재 상태에서 할 수 있는 가장 합리적인 방법이네요 👍
이후에 추가적인 알고리즘 적용하면 좋을 것 같아요
프로젝트 끝나기 전에 간단한 개선정도는 고민해봐도 좋을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 배경
여정을 기록 시 모든 위치 값을 기록하는 것을 방지하는 로직을 구현했습니다.
🔧 작업 내역
🧪 테스트 방법
📝 리뷰 노트
위치 보정에 대한 고민
5초, 5m< distance <50m의 기준은 임의로 정한 것이기에 정확도가 높은, 모든 상황을 고려한 필터링은 아닙니다.
📸 스크린샷