[홈] 무한 캐러셀 구현 #123
Open
[홈] 무한 캐러셀 구현 #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trumanfromkorea
requested changes
Dec 15, 2022
| @@ -15,7 +15,9 @@ final class HomeViewController: UIViewController, BaseViewController { | |||
|
|
|||
| var viewModel: HomeViewModel? | |||
| var disposeBag = DisposeBag() | |||
|
|
|||
|
|
|||
| var datasource: [HomeCapsuleCellItem] = [] | |||
There was a problem hiding this comment.
- datasource 라는 변수명이 CollectionView 의 DataSource 와 헷갈릴 가능성이 있다고 생각합니다!
- 해당 데이터는 ViewModel 이 가지고 있는게 자연스럽다고 생각합니다!
| @@ -56,7 +56,7 @@ final class HomeViewModel: BaseViewModel, CapsuleCellNeedable { | |||
| owner.output.featuredCapsuleCellItems.accept( | |||
| CapsuleType.allCases | |||
| .map { owner.getHomeCapsuleCellItem(capsules: capsuleList, type: $0) } | |||
| .compactMap({ $0 }) | |||
| .compactMap({ $0 }) // + Array(repeating: nil, count: Int.max) | |||
There was a problem hiding this comment.
큰 상관은 없지만 소괄호를 제외해도 될것 같아요
그리고 59번째 라인을 없애고 58번째 라인의 map 메소드를 compactMap 으로 바꿔도 같은 기능을 하지 않을까 싶네요~
| owner.datasource = capsuleCellItems | ||
| owner.homeView.capsuleCollectionView.reloadData() | ||
| DispatchQueue.main.async { | ||
| Thread.sleep(forTimeInterval: 0.01) |
There was a problem hiding this comment.
여기서 메인스레드를 재우는 이유가 있나요?!
There was a problem hiding this comment.
앱을 처음 실행 시 간혹 캡슐이 짤려서 두줄로 나오는 버그가 발생하였습니다.
저는 이 문제가 컬렉션뷰가 불린 후 초기 화면 설정을 위해 scrollToItem을 실행 시에 발생하는 버그라고 판단하였습니다.
따라서 먼저 컬렉션뷰가 초기에 멀쩡하게 호출된 후에 텀을 두어 scrollToItem 함수가 실행되도록 하고자 하였습니다........
그러나 간헐적으로 버그가 발생하기는 합니다..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
제출 전 필수 확인 사항:
작업 내용: