This repository has been archived by the owner on Jul 14, 2024. It is now read-only.
Load Retry #6
Merged
Load Retry #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the API responded with a 500
Code quality scoreUh oh! The code quality got worse for this PR! Better take a look!! 🚨
|
tom-mcculloch
approved these changes
Apr 16, 2024
motizuki
approved these changes
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the API responds with a 500 we weren't raising an error so the retry logic wasn't actually doing anything.
Typical reasons for the API to respond with a 500 is through a timeout due to a large volume of requests being sent too it.