Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrowed is_authenticated check in verfication_modal to only restrict… #3411

Conversation

timothyjrogers
Copy link
Contributor

… report button

Description

This PR makes a minor change to the is_authenticated check in the template for the external book link verification modal so that only the "Report Spam" button is locked behind login.

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

N/A

Documentation

N/A

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

I could not find any tests currently exercising this modal, although there are tests for the book and links view in general. I don't know if this change necessarily requires new tests since it just shifts a bit of content in the template, but I'd be happy to try and figure it out if needed.

@mouse-reeve mouse-reeve merged commit 7ff1ab9 into bookwyrm-social:main Aug 13, 2024
10 checks passed
@mouse-reeve
Copy link
Member

I don't know how to reasonably test this either (short of either inspecting the markup in python which sounds janky, or adding front end testing which would be a whole different endeavor entirely), so I went ahead and merged after testing manually. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External Link Modal confirmation window
2 participants