Add as:Hashtag
to activitypub context
#3370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, mastodon got more strict about validating the context of incoming federated messages. Currently, it appears that hashtags don't federate correctly to mastodon when
Note
objects (and probably alsoArticle
,Person
, etc.) contain atag
array with elements of typeHashtag
, but don't defineHashtag
in the@context
.I've verified that hashtags do not federate correctly (meaning: they're treated as normal links, posts with those hashtags don't show up in the hashtag search, etc.) from reading.taks.garden (bookwyrm 0.7.2) to either mastodon.gamedev.place (mastodon 4.2.8) or glitch.taks.garden (glitch-soc 4.3.0-alpha) before this change, and that they do federate correctly to both places after applying this change to reading.taks.garden.
Note: This only applies to objects that are federated "normally" (e.g. if a mastodon user follows a bookwyrm user), and you will not see the broken behavior if you "force" a note to be imported, e.g. by pasting a bookwyrm comment url into the mastodon search box
There was a previous discussion about this (over a year ago! 😱) at https://matrix.to/#/!zoxBMxLlvIyeEKkHuB:matrix.org/$1nDA0WY_s9NgaUFpki3GvX1yhV4KSF_8R1GFTwIQT4g?via=matrix.org&via=tchncs.de&via=mozilla.org