Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as:Hashtag to activitypub context #3370

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

Tak
Copy link
Contributor

@Tak Tak commented May 23, 2024

At some point, mastodon got more strict about validating the context of incoming federated messages. Currently, it appears that hashtags don't federate correctly to mastodon when Note objects (and probably also Article, Person, etc.) contain a tag array with elements of type Hashtag, but don't define Hashtag in the @context.

I've verified that hashtags do not federate correctly (meaning: they're treated as normal links, posts with those hashtags don't show up in the hashtag search, etc.) from reading.taks.garden (bookwyrm 0.7.2) to either mastodon.gamedev.place (mastodon 4.2.8) or glitch.taks.garden (glitch-soc 4.3.0-alpha) before this change, and that they do federate correctly to both places after applying this change to reading.taks.garden.

Note: This only applies to objects that are federated "normally" (e.g. if a mastodon user follows a bookwyrm user), and you will not see the broken behavior if you "force" a note to be imported, e.g. by pasting a bookwyrm comment url into the mastodon search box

There was a previous discussion about this (over a year ago! 😱) at https://matrix.to/#/!zoxBMxLlvIyeEKkHuB:matrix.org/$1nDA0WY_s9NgaUFpki3GvX1yhV4KSF_8R1GFTwIQT4g?via=matrix.org&via=tchncs.de&via=mozilla.org

@mouse-reeve
Copy link
Member

Oof! Thank you for investigating this

@mouse-reeve mouse-reeve merged commit 4d3d5d1 into bookwyrm-social:main Jun 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants