Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle serving BookWyrm on custom port #3350

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

Minnozz
Copy link

@Minnozz Minnozz commented Apr 7, 2024

  • Include correct protocol and port in remote IDs
  • Store correct protocol and port in BookwyrmConnector
  • Construct absolute URLs with correct protocol and port
  • Test custom port by running pytest with it

@Minnozz
Copy link
Author

Minnozz commented Apr 7, 2024

Hmm, CI itself is broken, unrelated to my change (probably because CI always uses the latest version of eslint instead of the one in dev-tools)

@Minnozz Minnozz marked this pull request as ready for review April 7, 2024 21:10
@Minnozz Minnozz requested a review from mouse-reeve April 7, 2024 21:10
@Minnozz Minnozz mentioned this pull request Apr 10, 2024
14 tasks
@Minnozz
Copy link
Author

Minnozz commented Apr 15, 2024

@bookwyrm-social/code-review this PR is ready for review

@mouse-reeve
Copy link
Member

Thank you for the housekeeping work along with this change!

@mouse-reeve mouse-reeve merged commit ad830dd into bookwyrm-social:main Apr 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants