-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements to Quotation pure content #3000
Minor improvements to Quotation pure content #3000
Conversation
Also, while we’re on this code, any reason why the title is wrapped in quotes, instead of The quotes seem fine for a plaintext serialization, but since I see |
No reason I can think of, as long as it's in the content of the serialization rather than an Article title, which it shuldn't be since this is a Note not an Article. You're welcome to change it. Chances are, at the time I simply didn't realize that Mastodon would render italics (but it does so that's a non-issue) |
Thanks, will do and ask for re-review. |
667c3a5
to
ce3885d
Compare
Done. I placed each item in a separate commit. |
This looks good, can you run the Python formatter? With that, I will be ready to merge |
8d1d810
to
fadf30b
Compare
Oops, my bad. Fixed. |
Sadly, this pulls other unrelated pull requests, because I didn't base it on v0.6.5 Replaces: commit bab28a8 Merge pull request bookwyrm-social#3000 from dato/position_serialization Minor improvements to Quotation pure content
pure_content()
refactor: shorter conditionalsendposition
when serializing Quotation