Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spanish articles #2953

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Conversation

MaggieFero
Copy link
Contributor

Hi! Our fork added Spanish-language articles to get us one step closer to the dream of Issue #2678 . It's just a little change, but probably other people would like it, too!

phildini and others added 5 commits March 6, 2023 20:39
Merge Updates from Upstream
Added articles for spanish language to list of articles in settings
@mouse-reeve
Copy link
Member

This is a great change and the only thing holding me back from merging it is that I'm not sure if the articles should be separated out by language. I need to take a look at how those languages are actually being used, and haven't done that yet.

@MaggieFero
Copy link
Contributor Author

MaggieFero commented Sep 6, 2023

Thanks! Keeping them separated out by language is really useful for our multi-lingual server because some languages' articles are significant words in other languages. The first one that comes to mind is one form of Dutch "the" ("het") is a common English term for sexuality.

@MaggieFero MaggieFero closed this Sep 6, 2023
@MaggieFero MaggieFero reopened this Sep 6, 2023
@MaggieFero
Copy link
Contributor Author

(Apologies for both the early-enter on the comment and the closed-then-reopened pull request, both were a single misclick)

@mouse-reeve
Copy link
Member

That makes sense! I'm going to merge and we can always revisit as time goes on. Thanks so much for adding to this.

@mouse-reeve mouse-reeve merged commit 703a569 into bookwyrm-social:main Oct 2, 2023
9 checks passed
@MaggieFero MaggieFero deleted the add-spanish-articles branch March 1, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants