-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations for utils #2917
Conversation
I'm not sure how to best resolve the conflicts on base_activity here |
@jderuiter as far as I can tell the conflicts are all with your work from last week so I'm also not sure whether the intention is to replace that work or build on it. Is it possible for you to rebase your |
Thanks for looking at this. This PR is actually older than last week's so probably those changes should take precedence. I'll have a look at it and fix this PR. It might take a couple of weeks before I have time for this.
|
The conflicts should have been resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just reading along and noticed these two things, in case they're useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me other than as noted. Thanks for those improvements to the isni
code.
Added type annotations to
bookwyrm.utils
. Inisni.py
I changed some code to handle the case whenET.Element.find
orET.Element.text
might returnNone
. I left two TODOs in the code where there is still some decision to make to either return nothing or raise an exception.