-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ids of labels in invite request form in admin #2912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but it could also work without the for
attribute: the <input>
element is wrapped inside the <label>
.
most certainly.
El mar., 1 de agosto de 2023 03:24, Joachim ***@***.***>
escribió:
… ***@***.**** approved this pull request.
Looks good, but it could also work without the for attribute: the <input>
element is wrapped inside the <label>.
—
Reply to this email directly, view it on GitHub
<#2912 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGBBZDKXPFBM5WZDPTJDSDXTDDMNANCNFSM6AAAAAA2SJSBVM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Would you prefer if I do it that way? it is probable better in the long run to not need ids to match. |
The simplest code is the better in my opinion. If we don’t need the id, there’s less risk of error if the Form has to change :)
… Le 1 août 2023 à 18:50, Abraham Toriz Cruz ***@***.***> a écrit :
Would you prefer if I do it that way? it is probable better in the long run to not need ids to match.
—
Reply to this email directly, [view it on GitHub](#2912 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AANS2TSMMB4P2YRUSA5LJGDXTEXU3ANCNFSM6AAAAAA2SJSBVM).
You are receiving this because you commented.Message ID: ***@***.***>
|
05ed6b8
to
dfa935b
Compare
1d26a20
to
4c526df
Compare
I updated the code based on this conversation |
Let me know if mor changes are necessary, or if a rebase is desirable |
Perfect, thank you so much! |
I noticed while using the admin interface that clicking on the "Set a question for invite requests" label didn't toggle the checkbox even though the input is inside the label. Turns out the reason is the
for=""
attribute that is not properly set.