Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ids of labels in invite request form in admin #2912

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

categulario
Copy link

I noticed while using the admin interface that clicking on the "Set a question for invite requests" label didn't toggle the checkbox even though the input is inside the label. Turns out the reason is the for="" attribute that is not properly set.

@categulario categulario changed the title fix pointed ids of labels in invite request form in admin fix ids of labels in invite request form in admin Jul 31, 2023
Copy link
Contributor

@joachimesque joachimesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it could also work without the for attribute: the <input> element is wrapped inside the <label>.

@categulario
Copy link
Author

categulario commented Aug 1, 2023 via email

@categulario
Copy link
Author

Would you prefer if I do it that way? it is probable better in the long run to not need ids to match.

@joachimesque
Copy link
Contributor

joachimesque commented Aug 2, 2023 via email

@categulario
Copy link
Author

I updated the code based on this conversation

@categulario
Copy link
Author

Let me know if mor changes are necessary, or if a rebase is desirable

@mouse-reeve
Copy link
Member

Perfect, thank you so much!

@mouse-reeve mouse-reeve merged commit 3deddf6 into bookwyrm-social:main Oct 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants