check for empty interval string

bookingcom · Jan 18, 2024 · bf13902 · bf13902
1 parent 4030828
commit bf13902
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/pkg/parser/interval.go b/pkg/parser/interval.go
@@ -6,6 +6,13 @@ import (
 
 // IntervalString converts a sign and string into a number of seconds
 func IntervalString(s string, defaultSign int) (int32, error) {
+	if len(s) == 0 {
+		return 0, ErrUnknownTimeUnits
+	}
+
+	if s == "-" || s == "+" {
+		return 0, ErrUnknownTimeUnits
+	}
 
 	sign := defaultSign
 

diff --git a/pkg/parser/interval_test.go b/pkg/parser/interval_test.go
@@ -40,6 +40,9 @@ func TestInterval(t *testing.T) {
 		err     string
 		sign    int
 	}{
+		{"", 0, "unknown time units", 1},
+		{"-", 0, "unknown time units", 1},
+		{"+", 0, "unknown time units", 1},
 		{"10x10s", 0, "unknown time units", 1},
 		{"10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000y", 0, "value out of range", 1},
 	}