Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaTracker 1.0 #569

Open
wants to merge 115 commits into
base: main
Choose a base branch
from
Open

MediaTracker 1.0 #569

wants to merge 115 commits into from

Conversation

bonukai
Copy link
Owner

@bonukai bonukai commented Jan 17, 2024

Major rewrite of entire project, frontend and backend, not yet completed.

Fronted has been fully redesign, but the progress on this is just starting. I have mainly focused on the backend rewrite. I have used trpc for API routes and zod for type checking. This allows for easier development and reduces type errors.

I have optimized the database, now queries are much faster and simpler, but they still allow for complex filters and sorting. Updating metadata, especially for TV shows, have been reworked as well. When metadata has changed for a tv season, and it cannot be updated (because user have marked those episodes as seen), only this season update will be skipped, rest of metadata will be updated.

Breaking changes

  • entire REST API has been rewritten, with the exception of the routes used by plugins
  • translations of backend logs have been removed
  • all environmental variables has been removed. Configuration can be set by web ui or cli
  • environmental variables in Docker has been removed or changed

Migration instructions

For those using SQLite (default) there are no extra steps, just update docker image.

If you are using a Postgres database, change environmental variable DATABASE_CLIENT from pg to PostgreSQL and use DATABASE_CONNECTION_STRING in form of postgres://user:password@host:port/database

New features:

Fixes

TODO:

  • details page
  • season page
  • progress page
  • progress
  • notifications
  • Trakt.tv import
  • statistics
  • mobile version
  • tests
  • Docker image
  • bundle fonts

Copy link

@mtricht mtricht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Can't wait for the release, Two minor comments that I needed to change to get this running on my machine.
And three questions:

  • You use prettier for backend and ESlint for frontend, why not just one?
  • Is dark mode on your todo list?
  • This PR is getting rather large, might I suggest introducing a 1.0 branch and merging changes into there?

client/src/App.tsx Outdated Show resolved Hide resolved
client/src/components/MediaItemViews.tsx Show resolved Hide resolved
bonukai and others added 2 commits March 16, 2024 11:20
rename import from  './router' to  './Router'

Co-authored-by: Michael van Tricht <[email protected]>
@bonukai
Copy link
Owner Author

bonukai commented Mar 16, 2024

  • You use prettier for backend and ESlint for frontend, why not just one?

Initially I was using prettier for formatting and later I have added ESlint for linting, but it make sense to use ESlint for also for formatting. First I have to fix errors that ESlint is showing on the backend :)

  • Is dark mode on your todo list?

Yes, dark mode is on my TODO list, but not on the initial release

  • This PR is getting rather large, might I suggest introducing a 1.0 branch and merging changes into there?

I wanted to do that, but I couldn't crate a pull request to merge into this branch, but now I have tried again, and obviously a change needs to be made on this branch, not on main 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants