-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaTracker 1.0 #569
base: main
Are you sure you want to change the base?
MediaTracker 1.0 #569
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Can't wait for the release, Two minor comments that I needed to change to get this running on my machine.
And three questions:
- You use prettier for backend and ESlint for frontend, why not just one?
- Is dark mode on your todo list?
- This PR is getting rather large, might I suggest introducing a 1.0 branch and merging changes into there?
rename import from './router' to './Router' Co-authored-by: Michael van Tricht <[email protected]>
Initially I was using prettier for formatting and later I have added ESlint for linting, but it make sense to use ESlint for also for formatting. First I have to fix errors that ESlint is showing on the backend :)
Yes, dark mode is on my TODO list, but not on the initial release
I wanted to do that, but I couldn't crate a pull request to merge into this branch, but now I have tried again, and obviously a change needs to be made on this branch, not on |
Wip catchup
WIP updates to allow postgres database connectivity
last and next airing
optimize list items seen filter
Major rewrite of entire project, frontend and backend, not yet completed.
Fronted has been fully redesign, but the progress on this is just starting. I have mainly focused on the backend rewrite. I have used trpc for API routes and zod for type checking. This allows for easier development and reduces type errors.
I have optimized the database, now queries are much faster and simpler, but they still allow for complex filters and sorting. Updating metadata, especially for TV shows, have been reworked as well. When metadata has changed for a tv season, and it cannot be updated (because user have marked those episodes as seen), only this season update will be skipped, rest of metadata will be updated.
Breaking changes
Migration instructions
For those using SQLite (default) there are no extra steps, just update docker image.
If you are using a Postgres database, change environmental variable
DATABASE_CLIENT
frompg
toPostgreSQL
and useDATABASE_CONNECTION_STRING
in form ofpostgres://user:password@host:port/database
New features:
Fixes
TODO: