Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for long paths on Windows #2016

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

glopesdev
Copy link
Member

@glopesdev glopesdev commented Sep 16, 2024

Ever since Windows 10 version 1607 it has been possible to extend the maximum file path by setting the following registry value:

Windows Registry Editor Version 5.00

[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem]
"LongPathsEnabled"=dword:00000001

However, applications also need to explicitly opt-in to long path support, which for .NET Framework is done via the App.manifest file. This PR explicitly adds the required longPathAware element to enable this support.

@glopesdev glopesdev added the feature New planned feature label Sep 16, 2024
@glopesdev glopesdev added this to the 2.9 milestone Sep 16, 2024
@glopesdev glopesdev changed the title Add support for long paths on windows Add support for long paths on Windows Sep 16, 2024
Copy link
Member

@PathogenDavid PathogenDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reminding me how awful the long path awareness documentation is.

Not sure what's weirder, the fact that the manifest requirement isn't mentioned here or that it isn't required for long paths to work in modern .NET (tested locally.)

@glopesdev glopesdev merged commit 3daadd6 into bonsai-rx:main Sep 17, 2024
10 checks passed
@glopesdev glopesdev deleted the long-paths branch September 17, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants