Update ScintillaNET to support modern .NET #1924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for modernizing the editor to run with the .NET Core stack there are a number of core dependencies which need to be upgraded or modified to run beyond .NET Framework. jacobslusser/ScintillaNET was until now one of the big concerns, since the project has been stale for almost 6+ years.
Fortunately, fernandreu/ScintillaNET now provides a .NET 6.0 compatible fork with a published NuGet package and the source code updates seem to be in great shape. Even though it still only targets windows, the component has even been updated with a new
arm64
runtime, which is a welcome addition for possibly targeting Windows on ARM.Since this fork only targets .NET 4.7.1 we took the chance to update all projects to target .NET 4.7.2 at a minimum, which is now our recommended target for new packages anyway.