Allow fetching json response from Flickr (for a few methods) #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable to fetch json-response from flickr (no unmarshalling).
Would be feasible for my app. I've done a 1st attempt in a way which will not break existing API, however, it is not very elegant.
The main change would be Transport#getJson.
Then i've added PhotosInterface#getInfoAsJson and getSizesAsJson (as alternative to getInfo) ... and i would need more.
(For this reason i've also introduced JSONResponse and JSONResponseImpl.)
I could add all the methods i need, but to do it for at least all get#methods on PhotosInterface and PhotosetsInterface it would be a lot of boilerplate work duplicating all the methods ... not a good approach.
So would be interested in how to enable json in a more elegant way (and to avoid to break API ... changing the signature of these getter methods).