Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Disable continuous terminal rewriting in CI #168

Open
JoshuaKGoldberg opened this issue Sep 21, 2023 · 1 comment · May be fixed by #169
Open

[Request] Disable continuous terminal rewriting in CI #168

JoshuaKGoldberg opened this issue Sep 21, 2023 · 1 comment · May be fixed by #169
Labels
enhancement New feature or request

Comments

@JoshuaKGoldberg
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Spinning out from JoshuaKGoldberg/create-typescript-app#859: when running Clack's spinners in a project in CI (e.g. GitHub Actions), you get a ton of CI logs:

│
◇  ✅ Passed migrating repository structure.
[25](https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/6264408991/job/17011040698?pr=858#step:5:26)l│
◒  Cleaning up files◐  Cleaning up files◓  Cleaning up files◑  Cleaning up files◒  Cleaning up files◐  Cleaning up files◓  Cleaning up files◑  Cleaning up files◒  Cleaning up files.◐  Cleaning up files.◓  Cleaning up files.◑  Cleaning up files.◒  Cleaning up files.◐  Cleaning up files.◓  Cleaning up files.◑  Cleaning up files.◒  Cleaning up files..◐  Cleaning up files..◓  Cleaning up files..◑  Cleaning up files..◒  Cleaning up files..◐  Cleaning up files..◓  Cleaning up files..◑  Cleaning up files..◒  Cleaning up files...◐  Cleaning up files...◓  Cleaning up files...◑  Cleaning up files...◒  Cleaning up files...◐  Cleaning up files...◓  Cleaning up files...◑  Cleaning up files...◒  Cleaning up files...◐  Cleaning up files◓  Cleaning up files◑  Cleaning up files◒  Cleaning up files◐  Cleaning up files◓  Cleaning up files◑  Cleaning up files◒  Cleaning up files◐  Cleaning up files.◓  Cleaning up files.◑  Cleaning up files.◒  Cleaning up files.◐  Cleaning up files.◓  Cleaning up files.◑  Cleaning up files.◒  Cleaning up files.◐  Cleaning up files..◓  Cleaning up files..◑  Cleaning up files..◒  Cleaning up files..◐  Cleaning up files..◓  Cleaning up files..◑  Cleaning up files..◒  Cleaning up files..◐  Cleaning up files...◓  Cleaning up files...◑  Cleaning up files...◒  Cleaning up files...◐  Cleaning up files...◓  Cleaning up files...◑  Cleaning up files...◒  Cleaning up files...◐  Cleaning up files...◓  Cleaning up files◑  Cleaning up files◒  Cleaning up files◐  Cleaning up files◓  Cleaning up files◑  Cleaning up files◒  Cleaning up files◐  Cleaning up files◓  Cleaning up files.◑  Cleaning up files.◒  Cleaning up files.◐  Cleaning up files.◓  Cleaning up files.◑  Cleaning up files.◒  Cleaning up files.◐  Cleaning up files.◓  Cleaning up files..◑  Cleaning up files..◒  Cleaning up files..◐  Cleaning up files..◓  Cleaning up files..◑  Cleaning up files..◒  Cleaning up files..◐  Cleaning up files..◓  Cleaning up files...◑  Cleaning up files...◒  Cleaning up files...◐  Cleaning up files...◓

Screenshot of the preceding code block in CI, showing many "Cleaning up files.." notices

Describe the solution you'd like

Could we an option to disable terminal animations, so each line is only logged once? Ideally that option would default to auto-detecting whether the environment is a CI one.

Describe alternatives you've considered

User-land code could avoid spinners in CI by doing the detection themselves. That's a lot of work for each consuming project though.

Additional context

I'd be happy to implement this - though might not have time soon.
@JoshuaKGoldberg JoshuaKGoldberg added the enhancement New feature or request label Sep 21, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 21, 2023
Open
3 tasks
@Mist3rBru
Copy link
Contributor

GitHub Actions sets common environment variables that we can use to determine if the code is running in their environment. We can do something like process.env.GITHUB_ACTIONS === 'true' to auto detect it.

@Mist3rBru Mist3rBru linked a pull request Sep 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(@clack/prompts): adapt spinner to CI environment Mist3rBru/clack
2 participants
@JoshuaKGoldberg @Mist3rBru