alternative signal handler stack should last #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SignalHandling instance destroyed, signal handler alternative stack is freed. However, the signal handler could still be called after that which causes use-after-free error.
|
CPU spins when I build a memory leak program with ASAN enabled and This is where this patch comes from. |
bombela
requested changes
Apr 8, 2021
| @@ -3847,6 +3847,9 @@ class Printer { | |||
|
|
|||
| #if defined(BACKWARD_SYSTEM_LINUX) || defined(BACKWARD_SYSTEM_DARWIN) | |||
|
|
|||
| const size_t stack_size = 8 * 1024 * 1024; | |||
| static char *alt_stack = static_cast<char *>(malloc(stack_size)); | |||
There was a problem hiding this comment.
yes but... this allocates RAM out of the control of the user. The intend of the SignalHandling class is to be used only if you want it. If you don't you shouldn't be paying anything for it.
|
So in the example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SignalHandling instance destroyed, signal handler alternative stack is freed.
However, the signal handler could still be called after that which causes use-after-free error.