Use xxhash for textures and palettes #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit seems incompatible with Median XL. With self-compiled glide dll the game window looks as followed: |
|
It was actually totally broken. Last change I made without testing caused all textures of the same size to get the same hash. Fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #140
Both the river of flame and various parts of act 5 need to hash over 1MB per frame. I've measured hashing adding about 20ms-50ms per frame which causes the frame rate to drop below 25fps at times. xxhash is more than 10x which is enough to remove get rid of the stalls.
Also fixes a potential collision issue with 32bit hashes. There are over 2000 hash collisions with fnv. Mods can add more on top of that.