Fixed non-zoom canvas events from not being triggered off on global d…

…isable
bogind · Jul 23, 2024 · 6769739 · 6769739
1 parent caa7f98
commit 6769739
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/metadata.txt b/metadata.txt
@@ -6,7 +6,7 @@
 name=QGIS Sound Effects
 qgisMinimumVersion=3.32
 description=Add sound effects to QGIS to make work less boring
-version=0.2.1
+version=0.2.2
 author=Dror Bogin
 [email protected]
 
@@ -21,6 +21,9 @@ repository=https://github.com/bogind/qgs_sound_effects
 hasProcessingProvider=yes
 # Uncomment the following line and add your changelog:
 # changelog=
+    2024-07-23 Version 0.2.2:
+        - bug fix:
+            - Fixed non-zoom canvas events from not being triggered off on global disable
     2024-07-15 Version 0.2.1:
         - bug fixes:
             - Fixed canvas events to trigger when the global "enable" was False

diff --git a/qgs_sound_effects.py b/qgs_sound_effects.py
@@ -531,9 +531,9 @@ def toggle_sound_effects(self):
         self.enabled = self.sound_effects_toggle.isChecked()
         self.set_setting('enabled', self.enabled)
         self.update_last_entry()
+        self.toggle_canvas_events()
         if self.enabled is True:
-            self.timer.start(1000)
-            self.toggle_canvas_events()
+            self.timer.start(1000)            
         else:
             self.timer.stop()