Catalyst::Action::Serialize::JSON with double encoding. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o prevent double encoding. Signed-off-by: Thiago Berlitz Rondon <[email protected]>
|
This should only break stuff if your data is improperly decoded in the first place, and I think it breaks things in some cases.. Can you give me a simple test or example of how the double encoding you're seeing is coming about? |
|
Do you know why Serialize::JSON::XS extends Serialize::JSON, and override _builder_encoder without utf8 ? |
Signed-off-by: Thiago Berlitz Rondon <[email protected]>
| @@ -16,7 +16,7 @@ has encoder => ( | |||
|
|
|||
| sub _build_encoder { | |||
| my $self = shift; | |||
| return JSON->new->utf8->convert_blessed; | |||
There was a problem hiding this comment.
this is ok, there's no need to remove ->utf8
|
@bobtfish for the content type header of application/json browsers need "application/json; charset=UTF-8" (at least chrome on linux) thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Serialize::JSON likes JSON::XS, without utf8 in _build_encoder to prevent double encoding.
Signed-off-by: Thiago Berlitz Rondon [email protected]