Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump checkstyle and spotbugs #583

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

bobbylight
Copy link
Owner

@bobbylight bobbylight commented Nov 23, 2024

Now that we're building with Java 11 (but still generating artifacts for Java 8+), we can bump our Checkstyle and Spotbugs dependencies.

I'm taking the opportunity to add a couple of new rules and options to Checkstyle as well. This isn't a full formatting/prettifier sweep though, just low-hanging fruit.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (37af1ed) to head (25baa24).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...java/org/fife/ui/rtextarea/RTextAreaEditorKit.java 25.00% 1 Missing and 5 partials ⚠️
...org/fife/ui/rsyntaxtextarea/WrappedSyntaxView.java 0.00% 1 Missing and 3 partials ⚠️
.../org/fife/ui/rsyntaxtextarea/RSyntaxUtilities.java 0.00% 0 Missing and 3 partials ⚠️
...ife/ui/rsyntaxtextarea/focusabletip/TipWindow.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #583   +/-   ##
=========================================
  Coverage     80.32%   80.33%           
  Complexity     7780     7780           
=========================================
  Files           178      178           
  Lines         30247    30247           
  Branches       3911     3911           
=========================================
+ Hits          24297    24299    +2     
+ Misses         4276     4274    -2     
  Partials       1674     1674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bobbylight bobbylight added this to the 3.5.3 milestone Nov 23, 2024
@bobbylight bobbylight self-assigned this Nov 23, 2024
@bobbylight bobbylight marked this pull request as ready for review November 23, 2024 20:01
@bobbylight bobbylight merged commit 46c3820 into master Nov 23, 2024
6 of 7 checks passed
@bobbylight bobbylight deleted the bump-checkstyle-and-spotbugs branch November 23, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant