Fix #581: Overzealous Mark Occurrences for single characters #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed as part of the issue in #575. The "Mark Occurrences" support usually highlights all instances of any token of type "identifier." Unfortunately many
TokenMaker
implementations style the characters,
,;
, and.
(and possibly others) as identifiers for aesthetic purposes only. This has the side effect of the Mark Occurrences support highlighting all instances of them if the caret pauses near them.At bets, this is visually surprising. At worst, it can cause the editor to hang for very large files with many instances of the character at the caret.
We should skip marking occurrences of non-word characters at any location. In 4.0.0 we can look at a more robust solution.