Refactor Function
#626
Merged
Refactor Function
#626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
technical debt
execution
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
==========================================
+ Coverage 72.64% 72.91% +0.26%
==========================================
Files 179 178 -1
Lines 13275 13226 -49
==========================================
Hits 9644 9644
+ Misses 3631 3582 -49
Continue to review full report at Codecov.
|
Benchmark for d5a603eClick to view benchmark
|
Benchmark for 05430fcClick to view benchmark
|
|
If I'm not mistaken, this would de facto close #387 and give a nice solution to #363 (comment), right? |
I guess so, forgot there was an PR to fix it. This PR only removes it but there will also be PR to add |
|
Looks good so far from what i can see. |
No. Not necessarily. They accomplish different goals. This PR does some prepwork for the new function design, and #627 ( |
HalidOdat
force-pushed
the
refactor/function
branch
from
ab6fb6f to
2c382c9
Compare
Benchmark for ec33490Click to view benchmark
|
- Added call to js object - Removed Function::call - Removed `Function::construct` and added `GcObject::construct` - Made Function an enum - Made the Function into an enum - Removed `InternalState` - Removed `internal_state.rs` file
HalidOdat
force-pushed
the
refactor/function
branch
from
2c382c9 to
2c14dca
Compare
Benchmark for c3b857cClick to view benchmark
|
Razican
reviewed
Aug 17, 2020
Co-authored-by: Iban Eguia <[email protected]>
Benchmark for 1686cd4Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for the function design discussed in #445
It changes the following:
Function::call()=>GcObject::call()this is done because we need the object that is being called to be garbage collected, because we put it in the environment. This was awkward before since we pass a clone of object and the access theFunctionand call it and pass the function object.Function::construct()=>GcObject::construct()same asFunction::call()Functionbe an enum since many fields that are for ordinary functions where there for builtins.InternalStatesince we will replace it with aNativeObject.RegExpin box because it was really big (136 bytes)Interpreter::create_builtin_function(name, length, function pointer) -> GcObjectInterpreter::register_global_function(name, length, function pointer)Functionfrom56bytes to48bytesObjectDatafrom144bytes to80bytesObjectfrom272bytes to192bytes