this was worse than before

NEWS.md

@@ -4,7 +4,6 @@
 - Remove CITATION file
 - Minor cosmetic changes to remove some Pedantic compiler messages in rcpp_crfsuite.cpp and crfsuite.h
 - Comment out rumavl_strerror in rumavl.h as the function is not used and in order to avoid 'warning: function declaration isn't a prototype [-Wstrict-prototypes]' 
-- Fix in mem_mgr of ramvl.c caused by update of valgrind 3.21.0 which is now flagging 'realloc with size 0' in packages
 
 # CHANGES IN crfsuite VERSION 0.4.1
 

src/crf/src/rumavl.c

@@ -1105,17 +1105,5 @@ static void *mem_mgr (RUMAVL *tree, void *ptr, size_t size)
     if (tree->alloc != NULL)
 	return tree->alloc(ptr, size, tree->udata);
 
-    //return realloc(ptr, size);
-    /* FIX CRAN warning START
-     The valgrind 'additional issue' checks are now being done with Fedora 38 
-     and its valgrind 3.21.0.  This is flagging 'realloc with size 0' in packages
-     */
-    if (size <= 0) {
-       free(ptr);
-       ptr = NULL;
-       return(ptr);
-    }else {
-      return realloc(ptr, size);
-    }
-    /* FIX CRAN warning END */
+    return realloc(ptr, size);
 }