Merge pull request #244 from zhiqiangxu/minor_opt_GetRandomPositiveInt

[nit] remove unnecessary cmp
bnb-chain · Jan 11, 2024 · 8a87b22 · 8a87b22
2 parents c8136c9 + 773b6af
commit 8a87b22
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/common/random.go b/common/random.go
@@ -42,7 +42,7 @@ func GetRandomPositiveInt(lessThan *big.Int) *big.Int {
 	var try *big.Int
 	for {
 		try = MustGetRandomInt(lessThan.BitLen())
-		if try.Cmp(lessThan) < 0 && try.Cmp(zero) >= 0 {
+		if try.Cmp(lessThan) < 0 {
 			break
 		}
 	}