Looking to help... #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix memory leaks for proc template
chore: Drop auto-generated boilerplate comments from CI configuration file
Update changelog since last release
Handle EOFError raised by Rack and raise BadRequest (and lock Rack version to 2.0 to pass tests)
* Run tests for Ruby versions >= 2.6 * Remove not needed checks for methods defined * Set required_ruby_version to >= 2.6 * Update READMEs with new Ruby versions
By extending Sinatra::Error, an error class can set the http status code on the response to a value other than 500. This commit fixes issues #1204 and #1518 where an error raised by a third party library that responded to http_status could set the status on the response. Any error outside of Sinatra errors will now always return a 500 status. This fixes an issue where an exception could leak sensitive data in the message to the browser. Errors that have http_status code 400 or 404 use the message as the body of the response. This is why it is imperative that these errors extend Sinatra::Error so that this is an explicit decision.
Ruby 2.x+ has a built-in implementation of `caller_locations`, which differs slightly from the Sinatra implementation of the same name. This removes the customized implementation in favor of the system one Co-authored-by: Jordan Owens <[email protected]>
Reel has been unmaintained since 2016, and we can stop supporting it in the upcoming version of Sinatra.
__dir__ is nice, and available.
Revert "Allow running with Rack 3. (#1811)"
We should adopt a code of conduct, so that we can point users from discord to when they join.
Closes #1786
Create CODE_OF_CONDUCT.md
Link to discord
HTTP ranges with non decimal characters is treated as range 0..0 as of Rack 2.2.6.2.
Require an approval from a maintainer before merge
See https://github.com/sinatra/sinatra/actions/runs/4138714331/jobs/7155450583#step:5:639 Failure was 1) Failure: IntegrationTest#test_with_webrick_does_not_generate_warnings_0 [/home/runner/work/sinatra/sinatra/test/integration_test.rb:56]:
Not enough bandwidth to battle these flaky specs on JRuby right now.
Also run async tests against Puma. Co-authored-by: Jordan Owens <[email protected]> Co-authored-by: Patrik Ragnarsson <[email protected]>
We use minitest for Sinatra's test suite but we weren't using its rake task. I've updated the Rakefile to require and use Minitest default rake task to simplify. Another change is to rename the `helper.rb` file to `test_helper.rb` because I think that name is used more in the community and require it directly without calling `File.expand_path`
The alias was deprecated: rack/rack#1811 Looks like Rack::Files appeared in rack 2.1.0 according to rack/rack@626272b Sinatra needs at least rack 2.2.4 (since v3.0.0) so this should be fine
Adds Tilt (https://rubygems.org/gems/tilt) to the CI matrix. It now resides at https://github.com/jeremyevans/tilt Changes `latest` to `head` because "latest" sounds a lot like "latest release" but we mean using the main/master branch of the repo of the dependency we test with. Matches `ruby-head`.
Fixes timing issue with Puma, adds 0.05 second to sleep, small changes to asserts and time calc. Ensure Puma creates its request serving thread at server boot: If min_threads is zero, the thread is created when the first request is received, which would increase the time for the test assert that failed. For CI, if min_threads is one, the thread is created as the server boots. Close puma/puma#3085
Ruby 3.2.0 removed Object#=~ in ruby/ruby#5383 Has been deprecated since Ruby 2.6.0: ruby/ruby@ebff9dc https://bugs.ruby-lang.org/issues/15231
From https://bugs.ruby-lang.org/issues/19230 > securerandom first checks if Random.urandom is available, and if not available, > it uses the openssl backend as a degeneration. However, the openssl backend > does not work because it internally uses Random.urandom to create a seed. If the proposed change in Bug #19230 were introduced, NotImplementedError would be raised and we would end up using the fallback in Sinatra anyway. Co-authored-by: Patrik Ragnarsson <[email protected]>
The changes worth mentioning from v3.0.5...055087c [ci skip]
Needed to run with Tilt 2.1.0 in CI until slim-template/slim#910 is part of a Slim release
- Rack changed default branch to "main" - rubydoc.info redirects to https:// [ci skip]
2.6.x is very old, https://rubygems.org/gems/liquid/versions 2.6.3 - July 23, 2015 (45.5 KB) Found these traces in history: - 7416777 - sinatra/sinatra-contrib@2dc03c8
`~> 6.0` will install latest Puma release, that's what `stable` do too Better we add this job once Puma 7 exist. [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the holidays, if anyone needs it.