Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manager: Use prebuilt toybox #641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SakuraKyuo
Copy link
Contributor

  • workarounds boot patch issue on some ROMs which using 4.x kernel

* workarounds boot patch issue on some ROMs which using 4.x kernel

Signed-off-by: SakuraKyuo <[email protected]>
@marat2509
Copy link
Collaborator

Are there any test results of this solution on devices where the boot patch failed with the built-in toybox?

@SakuraKyuo
Copy link
Contributor Author

SakuraKyuo commented Aug 31, 2024

Are there any test results of this solution on devices where the boot patch failed with the built-in toybox?

It has been tested on the devices which got boot patch failed, and the result is a successful patch. This commit mainly solves the problem that grep in the toybox of devices which using 4.x kernel cannot obtain the kernel configuration due to the lack of necessary argments and the patch script is forced to end.

Copy link
Collaborator

@pomelohan pomelohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think introducing a full toybox for only 1 small feature is acceptable. We’d like to use C++ to write a small parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants