-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hab install to download and install required distros #112
Draft
MHendricks
wants to merge
7
commits into
main
Choose a base branch
from
mikeh/download
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHendricks
force-pushed
the
mikeh/download
branch
4 times, most recently
from
December 6, 2024 20:29
15b5adb
to
26f3146
Compare
- If a object processed by `hab.utils.dump_object` has a dump method, it will be called. Verbosity is now passed to dump_object. - Improvements to Site.dump output including calling dump on file paths. - `Resolver.resolve_requirements` will now call `Solver.simplify_requirements` if passed a list automatically. - `MergeDict.default_format` now recursively formats dictionary values. - Documentation improvement.
MHendricks
force-pushed
the
mikeh/download
branch
from
December 6, 2024 23:56
26f3146
to
369b44b
Compare
Use the command `tox p` or `tox run-parallel` to enable parallel mode.
MHendricks
force-pushed
the
mikeh/download
branch
2 times, most recently
from
December 7, 2024 03:00
29367d7
to
988eca6
Compare
This class will replace the current code used to find distros. This allows us to implement sub-classes to change how they are found. For example to allow us to resolve dependencies hosted on the cloud for download and install. Add `hab.utils.glob_path` that supports globbing a pathlib.Path object with glob strings in the path.
These classes allow hab to resolve distros stored as .zip files both locally and on cloud services (aws s3 buckets). - Support sidecar .hab.json files next to the distro .zip files for remote services that don't support reading ranges of a file. - For services that support reading ranges of files like s3 it can download the .hab.json file from inside of the remote .zip file without downloading the entire .zip file first. - Add `hab.utils.loads_json` that raises the same errors as `load_json_file` but works on strings instead of files.
- Add `hab install` command that resolves all distros required to resolve multiple URI's and then download and install any missing distros. - Distro resolving is now handled by `DistroFinder` or sub-class. - Site now has a downloads dictionary that configures how `hab install` can resolve remote distros for installing locally. - `Resolver.distro_mode_override` with context can be used to change `Resolver.distro`'s output to the `Site.downloads["distros"] used to find remote distros to install.
MHendricks
force-pushed
the
mikeh/download
branch
from
December 13, 2024 03:20
988eca6
to
2aa900c
Compare
I've been thinking about dropping python 3.6 for a while and some tests I'm working on are suffering from |
MHendricks
force-pushed
the
mikeh/download
branch
from
December 14, 2024 03:07
2aa900c
to
dda68f5
Compare
This test will break python 3.6 and I'm likely to drop support for 3.6 because of it. The test fails because identical pathlib requirements don't compare equal in 3.6.
MHendricks
force-pushed
the
mikeh/download
branch
from
December 17, 2024 02:27
dda68f5
to
cf5cb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the cli command
hab install
. This resolves the required distros for multiple URI's against a remote download server, downloads and installs any missing distros.This also re-works how distros are resolved into a DistroFinder class or subclasses. These can be used to customize how distros are resolved by hab. This includes resolving distros from aws s3 buckets.
Checklist
Types of Changes
Proposed Changes