Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to swap axes orientation on rider constraint #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdilena
Copy link
Contributor

@mdilena mdilena commented Nov 16, 2024

Checklist

  • I have read the CONTRIBUTING.md document
  • I have added documentation regarding my changes where necessary

Types of Changes

  • Bugfix (change that fixes an issue)
  • New Feature (change that adds functionality)
  • Documentation Update (if none of the other choices apply)

Proposed Changes

Added the ability to swap axes orientations on the rider constraint node, similarly to what Maya's native motion path node can do. The AE Template has also been updated to organize the new attributes.

I also took the chance to add a native outputMatrix port in the output array, which I think was supposed to be there from the beginning as there was an aOutMat MObject declared that was never implemented.
Since I was dealing with MTransformationMatrix I changed the reorder rotations logic to use that class instead of MEulerRotations, so the decompose is not necessary anymore.

Here's a video showing the changes: Twist Spline - Rider Constraint Axes Orientation Feature

* Works like the native Maya's motion path, where forward and up vectors can be changed and flipped
* Updated rider constraint AE template to reflect the attributes changes
* Updated twist spline builder script so the rotation orders are connected to each rider node
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2024

CLA assistant check
All committers have signed the CLA.

@mdilena
Copy link
Contributor Author

mdilena commented Nov 19, 2024

Just a heads up that I may have to implement this for both type of twist tangent nodes as well, otherwise the twist matrix won't be correct. I might scrap this merge request and move the recomputeRotationMatrix function into twistSpline_maya.h so it's available across different modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants