Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spline data memory leak #39

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

RDelet
Copy link
Contributor

@RDelet RDelet commented Sep 17, 2024

Checklist

  • I have read the CONTRIBUTING.md document
  • I formatted my changes with black
  • I linted my changes with flake8
  • I have added documentation regarding my changes where necessary
  • Any pre-existing tests continue to pass
  • Additional tests were made covering my changes

Types of Changes

  • Bugfix (change that fixes an issue)
  • New Feature (change that adds functionality)
  • Documentation Update (if none of the other choices apply)

Proposed Changes

Fix memory leak with by use unique_ptr and make_unique
@CLAassistant
Copy link

CLAassistant commented Sep 17, 2024

CLA assistant check
All committers have signed the CLA.

@tbttfox
Copy link
Member

tbttfox commented Oct 22, 2024

Hey, sorry it took me a month and a half to get back to you. Production happens.

This looks good. Thanks for taking the time to help out!
Probably worth removing line 46 as x is no longer used. I'll do that before I make a release.

@tbttfox tbttfox merged commit 36fa26a into blurstudio:master Oct 22, 2024
14 checks passed
@tbttfox tbttfox mentioned this pull request Oct 22, 2024
@RDelet
Copy link
Contributor Author

RDelet commented Nov 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants