-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented a new NURBS output plug, added icons, AETemplates and a 2025 variant to github actions #27
Conversation
* added a nurbs data output plug + cleanup * Nurbs output, cleanup and AETemplates * Updated xcode in github actions
Icons? Nice! And you're right, it's definitely out of beta by this point. The only issue I have is how you built the knots array. Because the knot values are the parameterization of the spline, I think you should build the |
The .xpm is for the Node Editor and it's picked up automatically if it shares the same name as the node, while the png is scaled down to look nice in the outliner - I just realized I may have to provide Regarding the knots, I really wanted to hear your opinion on that, as I'm really no expert on NURBS and I remember it took me a while to get it right. What you mentioned makes total sense! Thank you! |
Ah, cool. I didn't know that about the xpm's. And the knot vector should be really easy. Because the twist spline will never be anything but a cubic bezier curve, you can get rid of all that extra logic and just repeat each value from remap 3 times in a row.
|
That worked great, tested it and generated correctly both a NURBS and a Bezier curve! |
I tested and it works great! |
Checklist
Types of Changes
Proposed Changes
This is another update I've been sitting on for a while, as the first time I used this plug-in on a project I ended up needing nurbs representation of the spline too, so I figured I could give it a try.
I also took the chance to clean up some code that I found out was unnecessary for what regards the new viewport 2.0 implementation, adding icons, attribute editor templates and making sure github actions are all up to date with latest stuff. I also fixed the plug-in version and bumped it to
1.1.0
, as I think we're past beta by this point, guess I considered 1.0.0 the previous merge request I made 😁I also moved the gifs to a local
images
folder, as it's nice to have them when the repo is cloned offline and the website is not reachable!Don't mind
twistSpline.h
andtwistTangentNode.cpp
changes, they're only whitespaces and it's because I accidentally included some experiments I was doing and rolled them back, they got trimmed when I re-saved the file 😅