-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#444 - overtime application process #447
Conversation
Co-authored-by: Krzysztof Rewak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I create an overtime request, the number of hours is always 0 (when I use localhost address, because when I'm using
http://toby.blumilk.localhost/overtime/requests/create
it is fine
- Please fix this validation massage, because it's a bit unclear.
-
For me default time it's shouldn't be midnight - I think that most of overtime is afternoon, so maybe it should be like 16:00? Or 15:00?
-
As an administrator, I don't think we need "Moje nadgodziny" - maybe just do like we have requests? I mean we have just "Requests".
- Date format - in all appliction we have dd.mm.yyy
-
As an employee should I be able to add overtime request, when I have pending/accepted vacation?
-
I think we should add here counter, when user has some overtime to accept
-
"Rozliczenie nadgodzin oznaczy nadgodziny jako rozliczone." - can we write this somehow different?
-
I think that admin should have possibility to cancel settled overtime; just in case - like we have canceling approved vacation requests.
-
Now numeration for overtime and requests looks the same. Maybe we should distinguish it somehow?
-
As I understand accepting/declining overtime in Slack will be implemented in another pr? If so, please create issue for that or at least add comment in issue - I don't want to forget about it.
-
For now, as an administrative approver I can accept overtime. I thought that only technical approver/admin can do that.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- As a employee I can settle overtime. Is it okay for us?
- When I click "Moje nadgodziny" in menu and click button "Dodaj wniosek" (so I'm on the page with creating overtime) on the menu the text "Moje nadgodziny" is not highlighted - in requests it is.
- So, when I have settled overtime for example 19.06.2024 15:00 - 19.06.2024 17:00, I can create another overtime 19.06.2024 16:00 - 19.06.2024 18:00. Is this okay for us?
|
ef81bac
Connected with #444.
Added the ability to add an overtime application, where the employee can add the date and time
from
andto
,type
of preferred overtime settlement. Added tests.Preview:
Screencast.from.10-06-24.13.47.25.webm