#378 - clickable events in calendar #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, when user goes to page "Calendar" he can hover mouse on icon and after that he see details about request. What's more, if he has permission, he can click on request number and he will be redirected to the request.
If he doesn't have permission, the request number is not clickable, but he can see request details.
What's more, it this pr is resolved task connected with drafts. For now employee can create request about sick vacation - everybody will see in the calendar (icon will be faded a bit) and on the dashboard that the employee created the request and he is absent, but the request waits for approval.
Moreover - all pending request are seen by all employees, but it's not the problem I think.
On the dashboard is placed information about that the request has state "pending"
On Slack (I mean daily summary) also individuals with requests in "pending" status are also included. However, there is no information indicating whether a request is pending or not. At this point, we wanted to simplify this. Moreover, if someone is highly interested in whether the request of a particular individual has been accepted or is pending, they can access the application in the system. Additionally, in the daily summary (in my opinion), employees are more concerned about who is absent rather than whether their request is accepted or pending.
This should close #378.
This should close #380.