-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#29 - grades page #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Conflicts: # composer.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change behaviour of clicking: [empty state] -> [green] -> [red] -> [empty] -> (...)
Now it's [empty] -> [red] -> [green] -> [red] -> (...), so you cannot go back to empty. Green is also more often used than red, so it should go first.
Hmm... Looks like first click can be single click and then you're getting green. Next one needs to be red? It's weird. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts :( |
# Conflicts: # composer.lock
Changed into:
For double-clicking? For example, if we want to add a rating to a cell, we have to click it and if we had an action that changed the color to one click, changing the rating would involve changing the color, which could be annoying. |
Or maybe display students names and in parenthesis index number? Like: Jan Kowalski (123123) and bold name or something? |
Fixed |
This should close #29.
A page called
oceny
has been added, where the student can see his or her grade table after selecting the semester, course, group and entering the index number. Added some tests.Preview:
Mobile view: