Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29 - grades page #70

Merged
merged 19 commits into from
Aug 13, 2024
Merged

#29 - grades page #70

merged 19 commits into from
Aug 13, 2024

Conversation

kamilpiech97
Copy link
Member

@kamilpiech97 kamilpiech97 commented Nov 10, 2023

This should close #29.

A page called oceny has been added, where the student can see his or her grade table after selecting the semester, course, group and entering the index number. Added some tests.

Preview:
screencapture-keating-blumilk-localhost-oceny-01hfhdrdjwnwt9pyd1r2zn8w9y-01hfhdrdkdx87djrg5pvzwt0vb-01hfhdrfa1t5wvdetm5g7y309t-2275-2023-11-20-08_37_35

Mobile view:
screencapture-keating-blumilk-localhost-oceny-01hfhdrdjwnwt9pyd1r2zn8w9y-01hfhdrdkdx87djrg5pvzwt0vb-01hfhdrfa1t5wvdetm5g7y309t-2275-2023-11-20-08_38_17

@kamilpiech97 kamilpiech97 marked this pull request as ready for review November 20, 2023 06:20
@kamilpiech97 kamilpiech97 requested a review from a team as a code owner November 20, 2023 06:20
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I add a column as a teacher it's blank:

image

But on "Oceny" page, when I enter some index number, the column is red

image

Should be like this?

@kamilpiech97
Copy link
Member Author

When I add a column as a teacher it's blank:

image

But on "Oceny" page, when I enter some index number, the column is red

image

Should be like this?

fixed

Copy link
Member

@krzysztofrewak krzysztofrewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change behaviour of clicking: [empty state] -> [green] -> [red] -> [empty] -> (...)

Now it's [empty] -> [red] -> [green] -> [red] -> (...), so you cannot go back to empty. Green is also more often used than red, so it should go first.

@krzysztofrewak
Copy link
Member

Hmm... Looks like first click can be single click and then you're getting green. Next one needs to be red? It's weird.

Copy link
Member

@krzysztofrewak krzysztofrewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there should be names of students as well (in dashboard panel):

image

@EwelinaSkrzypacz
Copy link
Member

Conflicts :(

@kamilpiech97
Copy link
Member Author

Hmm... Looks like first click can be single click and then you're getting green. Next one needs to be red? It's weird.

Changed into:

  1. first click going to green
  2. doubleclick going to red
  3. and next doubleclick going like this: white => green => red => white....

For double-clicking? For example, if we want to add a rating to a cell, we have to click it and if we had an action that changed the color to one click, changing the rating would involve changing the color, which could be annoying.

@kamilpiech97
Copy link
Member Author

kamilpiech97 commented Jul 11, 2024

Also there should be names of students as well (in dashboard panel):

image

Let's check doubleclick :D - name should display

@EwelinaSkrzypacz
Copy link
Member

Or maybe display students names and in parenthesis index number?

Like: Jan Kowalski (123123) and bold name or something?

@kamilpiech97
Copy link
Member Author

Or maybe display students names and in parenthesis index number?

Like: Jan Kowalski (123123) and bold name or something?

Fixed

@kamilpiech97 kamilpiech97 merged commit 870abb4 into main Aug 13, 2024
3 checks passed
@kamilpiech97 kamilpiech97 deleted the #29-grades-page branch August 13, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grades page
3 participants