Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#21 - design 404 page #59

Merged
merged 6 commits into from
Oct 12, 2023
Merged

#21 - design 404 page #59

merged 6 commits into from
Oct 12, 2023

Conversation

EwelinaSkrzypacz
Copy link
Member

This should close #21.

image

@EwelinaSkrzypacz EwelinaSkrzypacz marked this pull request as ready for review October 12, 2023 06:17
@EwelinaSkrzypacz EwelinaSkrzypacz requested a review from a team as a code owner October 12, 2023 06:17
kamilpiech97
kamilpiech97 previously approved these changes Oct 12, 2023
Copy link
Member

@krzysztofrewak krzysztofrewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move images to public/images/ directory.

Comment on lines 28 to 30
if (!app()->environment("production")) {
return $response;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rethinking that, it doesn't have sense, so I removed it.

@EwelinaSkrzypacz EwelinaSkrzypacz merged commit 78a5470 into main Oct 12, 2023
@EwelinaSkrzypacz EwelinaSkrzypacz deleted the #21-design-404-page branch October 12, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design 404 page
4 participants