#24 - news #39
Merged
#24 - news #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # routes/web.php
kamilpiech97
previously approved these changes
Aug 13, 2024
There was a problem hiding this comment.
- In validation message, the word "content" is not translated
Pole content jest wymagane.
- Date of publication is shown in UTC, but I think we should show in our timezone. Also styling of text doesn't work
- When I click on the news to go to details, I see some random text
- When no news are published, we should make some nice empty state or at least hide pagination and add text like "Brak aktualności"
|
@krzysztofrewak conflicts |
# Conflicts: # composer.lock # routes/web.php
|
@EwelinaSkrzypacz, all done.
|
|
@EwelinaSkrzypacz, we cannot do anything, as we are sending formatted data from backend. |
EwelinaSkrzypacz
previously approved these changes
Aug 19, 2024
|
@EwelinaSkrzypacz, I added |
kamilpiech97
previously approved these changes
Aug 19, 2024
# Conflicts: # composer.lock # package-lock.json # package.json
kamilpiech97
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially solves #24.