Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- namespaces and facades clean-up #125

Merged
merged 4 commits into from
Aug 21, 2024
Merged

- namespaces and facades clean-up #125

merged 4 commits into from
Aug 21, 2024

Conversation

krzysztofrewak
Copy link
Member

This PR:

  • changes namespace from App to Keating
  • removes facades and replaces them with direct injections

@krzysztofrewak krzysztofrewak requested a review from a team as a code owner August 20, 2024 13:11
@krzysztofrewak
Merge remote-tracking branch 'origin/main' into cleanup
312239b
@krzysztofrewak
Merge remote-tracking branch 'origin/main' into cleanup
6a36be9 
# Conflicts:
#	app/Http/Controllers/Dashboard/CourseController.php
#	app/Http/Requests/CourseRequest.php
#	app/Observers/NewsObserver.php
#	database/factories/CourseFactory.php
#	routes/web.php
#	tests/Feature/CourseTest.php
#	tests/Feature/NewsTest.php
kamilpiech97
kamilpiech97 previously approved these changes Aug 21, 2024
View reviewed changes
@krzysztofrewak krzysztofrewak merged commit dc65c4c into main Aug 21, 2024
2 checks passed
@krzysztofrewak krzysztofrewak deleted the cleanup branch August 21, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@kamilpiech97 kamilpiech97 kamilpiech97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krzysztofrewak @kamilpiech97 @EwelinaSkrzypacz