Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 - homepage frontend #16

Merged
merged 62 commits into from
Aug 19, 2024
Merged

#2 - homepage frontend #16

merged 62 commits into from
Aug 19, 2024

Conversation

JokeUrSelf
Copy link
Collaborator

@JokeUrSelf JokeUrSelf commented Aug 12, 2024 •
edited
Loading

Screens:

full
full
login
modal
register
register

@JokeUrSelf JokeUrSelf linked an issue Aug 12, 2024 that may be closed by this pull request
Home page - frontend #2
Closed
4 tasks
EwelinaSkrzypacz

This comment was marked as resolved.

Sign in to view

kamilpiech97
kamilpiech97 reviewed Aug 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
resources/css/app.css Outdated Show resolved Hide resolved
resources/js/components/Home/RegisterBanner.vue Outdated Show resolved Hide resolved
@kamilpiech97

This comment was marked as resolved.

Sign in to view
kamilpiech97
kamilpiech97 reviewed Aug 19, 2024
View reviewed changes
resources/css/app.css Outdated Show resolved Hide resolved
resources/js/components/Home/AuthBanner.vue Outdated Show resolved Hide resolved
resources/js/components/Home/AuthSection.vue Show resolved Hide resolved
resources/js/components/Home/InformationButton.vue Show resolved Hide resolved
resources/js/components/Home/LoginForm.vue Outdated Show resolved Hide resolved
resources/js/components/Home/RegisterForm.vue Outdated Show resolved Hide resolved
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add screenshots to the description - not all reviewers will run the project - they just read code and look on screenshots.
  2. Now I see that this "Collegium Witelona: Testy" in footer sounds bad - I will stay with "Collegium Witelona Uczelnia Państwowa"

image

  1. I think that instead of "Wybierz szkołę" the text "Szkoła" will be better. Also the dropdown with schools is not look like dropdown - please add some arrow or something that indicates that user can click on this field and list with schools will be shown

image

  1. Mobile view - please translate buttons

image

  1. Mobile view - The field "Nazwisko" will look better under field "Imię"

image

  1. Maybe we should add option to login form like "Zapamiętaj mnie"?

EwelinaSkrzypacz
EwelinaSkrzypacz approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now it's okay (for me). When we get some content, we will make some adjustments 😊

@JokeUrSelf JokeUrSelf merged commit 733db7b into main Aug 19, 2024
3 checks passed
@JokeUrSelf JokeUrSelf deleted the 2-home-page-frontend branch August 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@kamilpiech97 kamilpiech97 kamilpiech97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Home page - frontend
4 participants
@JokeUrSelf @kamilpiech97 @EwelinaSkrzypacz @tiankongldp