Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#112 - Align app's design with the sponsor's branding #121

Merged
merged 18 commits into from
Dec 2, 2024
Merged

#112 - Align app's design with the sponsor's branding #121

merged 18 commits into from
Dec 2, 2024

Conversation

JokeUrSelf
Copy link
Collaborator

@JokeUrSelf JokeUrSelf commented Nov 24, 2024 •
edited
Loading

Should close #111
Should close #112

Added sponsor's logo to the home page.
Aligned theme with the sponor's design.

image

@JokeUrSelf JokeUrSelf linked an issue Nov 24, 2024 that may be closed by this pull request
Align app's colors with sponsors branding #112
Closed
@JokeUrSelf JokeUrSelf changed the title feat: add theme switch #112 - Align app's colors with sponsors brandin Nov 24, 2024
@JokeUrSelf JokeUrSelf changed the title #112 - Align app's colors with sponsors brandin #112 - Align app's colors with sponsors branding Nov 24, 2024
@JokeUrSelf JokeUrSelf linked an issue Nov 24, 2024 that may be closed by this pull request
Update sponsors' logos #111
Closed
@JokeUrSelf JokeUrSelf changed the title #112 - Align app's colors with sponsors branding #112 - Align app's design with a sponsor's branding Nov 24, 2024
@JokeUrSelf JokeUrSelf changed the title #112 - Align app's design with a sponsor's branding #112 - Align app's design with the sponsor's branding Nov 24, 2024
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Email design is not changed

image

  1. For demo purposes switching between themes from the footer is okay, but in final version I don't know how it should be useful

@EwelinaSkrzypacz
Copy link
Member

Tests failed :(

@JokeUrSelf JokeUrSelf marked this pull request as draft November 26, 2024 16:05
@JokeUrSelf
Copy link
Collaborator Author

  1. For demo purposes switching between themes from the footer is okay, but in final version I don't know how it should be useful

Is that ok, if I move the theme switch to the profile page? In that case only authorized users will be able to change a theme

@JokeUrSelf JokeUrSelf marked this pull request as ready for review December 1, 2024 22:37
@JokeUrSelf
Copy link
Collaborator Author

Is that ok, if I move the theme switch to the profile page? In that case only authorized users will be able to change a theme

I removed the theme switch and set sponsors' theme as a primary one

EwelinaSkrzypacz
EwelinaSkrzypacz requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missclick - please change favicon - favicon.png is still purple

@JokeUrSelf JokeUrSelf merged commit 20bc7de into main Dec 2, 2024
3 checks passed
@JokeUrSelf JokeUrSelf deleted the 112-align-apps-colors-with-sponsors-branding branch December 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@AmonDeShir AmonDeShir AmonDeShir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align app's colors with sponsors branding Update sponsors' logos
3 participants
@JokeUrSelf @EwelinaSkrzypacz @AmonDeShir