Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5 - Bump dev dependencies #14

Merged
merged 6 commits into from
Jun 11, 2024
Merged

#5 - Bump dev dependencies #14

merged 6 commits into from
Jun 11, 2024

Conversation

BarTracz
Copy link
Contributor

@BarTracz BarTracz commented Jun 10, 2024

I bumped some dependencies, looks like there are no problems. Minimum php version for dev is 8.2 due to phpunit requirements.
This should close #5

i bumped some dependencies, there is issue with Carbon i guess. But looks like phpunit and codestyle works fine.
Copy link
Member

@krzysztofrewak krzysztofrewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PHP version in docker-compse.yml to 8.2 as well.

@BarTracz BarTracz requested a review from krzysztofrewak June 10, 2024 08:22
composer.json Outdated
},
"require-dev": {
"blumilksoftware/codestyle": "^1.10",
"phpunit/phpunit": "^9.5"
"blumilksoftware/codestyle": "^2.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update it to 3.1, as this is the newest version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. I took versions from Toby, thats why it was 2.8 not 3.1.

@BarTracz BarTracz requested a review from krzysztofrewak June 10, 2024 09:22
@BarTracz BarTracz merged commit 44cef25 into main Jun 11, 2024
2 checks passed
@BarTracz BarTracz deleted the #5-Bump-dev-dependencies branch June 11, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump dev dependencies
2 participants