Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9 - showing current tile #12

Merged
merged 8 commits into from
Jun 11, 2024
Merged

#9 - showing current tile #12

merged 8 commits into from
Jun 11, 2024

Conversation

krzysztofrewak
Copy link
Member

This is some old pull request I worked on. @BarTracz, please check how it works and review it.

BarTracz added 2 commits June 6, 2024 17:37
i added index.php file to check if everything works properly
@BarTracz
Copy link
Contributor

BarTracz commented Jun 6, 2024

image
For me it looks good so i guess we can merge it

index.php Outdated Show resolved Hide resolved
Copy link
Member

@AleksandraKozubal AleksandraKozubal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be nice to add ports and command section, allowing access to app via localhost. For example
ports: - "8080:8080"
command: php -S 0.0.0.0:8080 -t /application

Maybe we could add a simple description of the dev setup steps?

@krzysztofrewak
Copy link
Member Author

I think it would be nice to add ports and command section, allowing access to app via localhost. For example

`ports:

  - "8080:8080"`

command: php -S 0.0.0.0:8080 -t /application

Maybe we could add a simple description of the dev setup steps?

Do we really need this in library repository?

@AleksandraKozubal
Copy link
Member

I think it would be nice to add ports and command section, allowing access to app via localhost. For example
`ports:

  - "8080:8080"`

command: php -S 0.0.0.0:8080 -t /application
Maybe we could add a simple description of the dev setup steps?

Do we really need this in library repository?

I thought of it as a dev way of presenting (especially useful for code reviews) that would be removed after the work was finished - but sure, I won't insist on it

@krzysztofrewak krzysztofrewak requested a review from BarTracz June 10, 2024 06:34
BarTracz
BarTracz previously approved these changes Jun 10, 2024
@BarTracz BarTracz requested a review from kamilpiech97 June 10, 2024 09:53
@krzysztofrewak krzysztofrewak merged commit 9ca0745 into main Jun 11, 2024
2 checks passed
@krzysztofrewak krzysztofrewak deleted the #9-current-tile branch June 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants