#41 - Add fetching workflow jobs #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata from labels, calculating job time
kamilpiech97
reviewed
Jul 8, 2024
kamilpiech97
requested changes
Jul 8, 2024
kamilpiech97
reviewed
Jul 8, 2024
kamilpiech97
approved these changes
Jul 8, 2024
orlowski11
merged commit 62caf89
into
#2-add-getting-data-from-github-api
1 check passed
AmonDeShir
added a commit
that referenced
this pull request
Aug 5, 2024
* #38 - Create models and migrations for data from GitHub api (#42) * added models, migrations, dtos and factories * cleanup * Update app/DTO/WorkflowJobDTO.php Co-authored-by: Kamil Piech <[email protected]> --------- Co-authored-by: Kamil Piech <[email protected]> * #39 - Add fetching repositories (#53) * added fetching repositories service and tests * changed repositories to collection & added timestamps * fixed organization id in creating dto * removed throwing exception on empty collection * #40 - Add fetching workflow runs (#54) added fetching workflow runs and tests * #41 - Add fetching workflow jobs (#55) * added services and tests for fetching workflow jobs, getting runner data from labels, calculating job time * added checking if jobs are already fetched before sending request * fixes & carbon for calculating job time * - Fetching data from api async (#56) * added route and controller method for fetching data * changed to asynchrous fetching data * removed unnecessary log * cleanup * added redis variables to env.ci * added redis to workflows * remove redis from workflow * remove redis from env.ci * add apple to job factory * split FetchDataFromApi into multiple jobs - Fixed a bug where AssignUserToOrganizationsService failed if the user organization did not exist - Split FetchDataFromApi.php into multiple jobs * fix linter errors * use pricing values from config * fix inconsistent response() usage * use Symfony HTTP status codes * use strict comparison in in_array() --------- Co-authored-by: Kamil Piech <[email protected]> Co-authored-by: AmonDeShir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #41
added services and tests for: