-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#65 - purge mode #86
#65 - purge mode #86
Conversation
|
||
return [ | ||
"default" => env("DB_CONNECTION", "mysql"), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need that space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it why it's working like this. According to this (https://mlocati.github.io/php-cs-fixer-configurator/#version:3.8|fixer:no_extra_blank_lines example 6) these empty lines should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a task for that: #87
conflicts @krzysztofrewak |
# Conflicts: # src/Configuration/Defaults/CommonRules.php # tests/codestyle/CodestyleTest.php
Resolved. |
For new Laravel instances sometimes I would like yo get rid of all comments, especially in configuration files. This should allow it by entering "purge mode" in
codestyle.php
for one run:With purge mode this:
will be refactored into this:
This should close #65.