Skip to content

Commit

Permalink
Move curl and httpie to final layer in dockerfile (#821)
Browse files Browse the repository at this point in the history
* move curl and httpie to final layer in dockerfile

* docker fix changelog
  • Loading branch information
dylanmcreynolds authored Nov 23, 2024
1 parent cb31d56 commit 79bb4dd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Write the date in place of the "Unreleased" in the case a new version is release

## Unreleased

- Fix curl and httpie installation in docker image.

### Added

- Add HTTP endpoint `PATCH /array/full/{path}` to enable updating and
Expand Down
5 changes: 2 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ FROM python:3.12-slim as builder
# We need gcc to compile thriftpy2, a secondary dependency.
RUN apt-get -y update && apt-get install -y git gcc

# We want cURL and httpie so healthchecks can be performed within the container
RUN apt-get install -y curl httpie

WORKDIR /code

# Ensure logs and error messages do not get stuck in a buffer.
Expand Down Expand Up @@ -52,6 +49,8 @@ FROM python:3.12-slim as runner
ENV VIRTUAL_ENV=/opt/venv
ENV PATH="$VIRTUAL_ENV/bin:$PATH"
COPY --from=builder $VIRTUAL_ENV $VIRTUAL_ENV
# We want cURL and httpie so healthchecks can be performed within the container
RUN apt-get update && apt-get install -y curl httpie

WORKDIR /deploy
RUN mkdir /deploy/config
Expand Down

0 comments on commit 79bb4dd

Please sign in to comment.