Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: move the recursive collect_asset_docs up to Device #1032

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tacaswell
Copy link
Contributor

While talking to @jklynch about how asset document collection works I noted that the recursive fallback was implemented in the AreaDetector related classes. As part of a push to refactor and (hopefully) simplify how we manage external resources it would be good to pull the recursive discovery and accumulation up to the Device level.

@ZLLentz
Copy link
Member

ZLLentz commented May 10, 2022

This looks very sensible 👍

Functionally, there's a small change here of only checking kind='normal'- could that be related to some of the area detector test failures?

1 similar comment
@ZLLentz
Copy link
Member

ZLLentz commented May 10, 2022

This looks very sensible 👍

Functionally, there's a small change here of only checking kind='normal'- could that be related to some of the area detector test failures?

@tacaswell tacaswell force-pushed the enh_recurse_collect_asset_docs branch from 7415212 to 724c805 Compare May 10, 2022 21:32
@tacaswell
Copy link
Contributor Author

rebased and tweaked the test a bit.

It makes sense that collect asset docs and read should hit the same children.

@@ -1237,6 +1237,11 @@ def read(self):
res.update(component.read())
return res

def collect_asset_docs(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring would be nice!

@tacaswell
Copy link
Contributor Author

Yup, this is super broken and I have no idea why :(

I assume multiple inheritance is involved....

@tacaswell tacaswell marked this pull request as draft May 11, 2022 01:31
@tacaswell tacaswell force-pushed the enh_recurse_collect_asset_docs branch from 724c805 to 06f5cfa Compare June 27, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants