Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out common AD file plugin logic into core writer class, create ADTiffWriter #606

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jwlodek
Copy link
Member

@jwlodek jwlodek commented Oct 8, 2024

This now seems to mostly work, at least from the collection side. The data cannot be read back via tiled at the moment, however, so for now marking as draft, since I may need to edit the docs generated somewhat to account for this.

Addresses #595 .

TODO:

  • Add tests for tiff writer
  • Make sure we can read the data back through tiled
  • Make sure HDF writer still works as it did.

@jwlodek
Copy link
Member Author

jwlodek commented Oct 8, 2024

@genematx Here are the ophyd async changes that introduce tiff writer support, specifically you can look at collect_stream_docs in the ADWriter class to see what I am emitting

@jwlodek jwlodek marked this pull request as ready for review October 10, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant